MUSHclient 4.45, crashes on closing - WINE

Posted by Rakon on Mon 18 Jan 2010 08:36 AM — 8 posts, 35,767 views.

USA #0
Today I went to upgrade from the stable 4.43 version to MUSH 4.45. It did not go so well.


System:
Linux kernel 2.6.31-17-generic #54-Ubuntu SMP x86_64 GNU/Linux

Wine 1.01 stable

MUSHclient 4.45


MUSHclient starts up, and seemingly runs fine. However, when I went to disconnect from my MUD it froze horribly. I had to force kill the client. I tried to reproduce the error again, and it indeed froze my entire xorg. Only by forcing an x-windows restart, was I able to restore my desktop to usability.

Tracing the issue, I ran MUSH445 in WINEs emulated desktop, and started debugging. I logged into the MUD then promptly quit. Again, the error arose, but as MUSHclient was in the virtual desktop I was able to close it and view the console.

This is the error returned then disconnected from the MUD :

 Debugging interfaces not available - debugging is disabled..
err:menu:MENU_GetSysMenu failed to load system menu!
err:local:LOCAL_GetBlock not enough space in USER heap 10d7 for 80 bytes
err:menu:MENU_GetSysMenu failed to load system menu!

<SNIP> Above message about 400 times

err:seh:setup_exception_record stack overflow 816 bytes in thread 0009 eip f748fd15 esp 00231000 stack 0x230000-0x231000-0x330000
chris@penquin:~/.wine/drive_c/Program Files/MUSHclient445$ 


The error does not occur in MUSHclient 4.43

**EDIT** Forum post limit cut me off... 6000 chars only.
Amended on Mon 18 Jan 2010 08:37 AM by Rakon
Netherlands #1
How does v4.44 fare?

Also, unable to allocate heap memory points at either a pretty serious memory leak, or a bug in Wine. Or a combination of the two.

Edit: Looking at v4.44 release notes, I spot this:

Quote:
5. Fixed a bug where, under newer versions of Visual Studio, MUSHclient would crash when disconnecting from a world (this doesn't apply to the downloaded version, but affected people trying to compile from the source).


Seems like Wine has the reverse bug somehow? o.O
Amended on Mon 18 Jan 2010 08:59 AM by Worstje
USA #2
I downloaded the 4.45 from the forums thread, not compiled on my own though.

Haven't tested 4.44, though if something changed in THAT version towards fixing a crash, and in 4.45 it's still crashing; all I can assume is that that fix, is causing the crash in 4.45.

As I said, it doesn't occur in 4.43, so definitely an issue in a version paste that.
Netherlands #3
You can find v4.44 in the same location as the v4.45 one. Just change the number in the link. (Or remove the file alltogether, you'll get a listing of all MUSHclient releases in history.. or well, everything but the pretty early releases).
Australia Forum Administrator #4
My testing under Ubuntu seems to indicate that the problem started in version 4.44, in particular CPU activity seems to increase on a disconnect, and the disconnection is not completed.

From the release notes for 4.44, I see this:


2. Changed the processing of a MUD disconnection message to attempt to retrieve any outstanding packets before closing the connection. See http://www.gammon.com.au/forum/?id=9696


I suspect this is the cause, and will look into it. Perhaps the "attempt to retrieve any outstanding packets" goes into a loop.
Australia Forum Administrator #5
I was right, it was that change that did it. I have rolled that back in version 4.46. It was only fixing a minor issue anyway, and indeed I never got confirmation that it fixed anything.
USA #6
Thank you for the prompt fix, Nick.
USA #7
Nick Gammon said:
I never got confirmation that it fixed anything.

It didn't, no. I completely forgot about it or I'd have mentioned it to you. *cough*