Crashing on text

Posted by Robin Lionheart on Tue 24 Jan 2006 03:51 AM — 10 posts, 34,725 views.

Robin Lionheart Tue 24 Jan 2006 03:51 AM #0

For some time I have used this color highlighting trigger on ifMUD:

\(to ([lL]ionheart|LH)\)|[lL]ionheart

Upon upgrading to MUSHclient 3.72, whenever this trigger goes off, MUSHclient crashes.

Nick Gammon Australia Forum Administrator Tue 24 Jan 2006 05:21 AM #1

It doesn't crash when I try it, can you post the whole trigger please?

See:

http://www.gammon.com.au/forum/bbshowpost.php?bbsubject_id=4776

Also, the exact line that causes the trigger to crash.

To narrow it down to that exact trigger, you could make a separate world file, with nothing but that trigger in it, and confirm that it still crashes.

Quote:

Upon upgrading to MUSHclient 3.72 ...

Which version did you upgrade from? Maybe something introduced in an intermediate version is responsible.

Webkid USA Wed 25 Jan 2006 09:23 PM #2

I have been having trouble with v3.72 as well, so much so that I went back to using v3.70. It seems to be when a trigger changes the background text color it crashes.

Below is an example of my trigger that crashes in v3.72.


<triggers>
  <trigger
   custom_colour="17"
   enabled="y"
   keep_evaluating="y"
   match="You stop dodging and weaving around your opponent."
   regexp="y"
   repeat="y"
   sequence="100"
   other_text_colour="yellow"
   other_back_colour="darkgray"
  >
  </trigger>
</triggers>

I'm not sure if it does so in v3.71 or not, but I can try it out if need be.

Zeno USA Wed 25 Jan 2006 09:43 PM #3

I tested that exact trigger, Webkid. On 3.72 it didn't crash. No problems.

Webkid USA Wed 25 Jan 2006 10:26 PM #4

Ok, so I just took screenshots of it crashing. I also just tried v3.71 and it didn't crash then but in v3.72 it does.

Screenshot 1(http://www.r2wk.net/files/screenshot_01.gif)
Screenshot 2(http://www.r2wk.net/files/screenshot_02.gif)
Screenshot 3(http://www.r2wk.net/files/screenshot_03.gif)

Also here(http://www.r2wk.net/files/appcompat.txt) is one of the error logs.

Hope this helps.

Zeno USA Wed 25 Jan 2006 10:37 PM #5

What OS are you using? I'm using Windows XP SP2.

Webkid USA Wed 25 Jan 2006 11:25 PM #6

I'm using XP Pro with SP2.

Nick Gammon Australia Forum Administrator Thu 26 Jan 2006 02:17 AM #7

I strongly suspect this crash is related to the new feature in version 3.72:

"Added trigger option to only colour the text or background colour when colouring matched text. The default is to keep the existing behaviour, which is to colour both.".

However, your trigger colours both which should have taken the existing code path. Also, I can't reproduce it on that exact trigger.

Can you give the text that you are matching on?

For a regular expression it is unusual to have the trailing dot like that, perhaps you mean:



You stop dodging and weaving around your opponent\.

However that would not cause the crash.

Nick Gammon Australia Forum Administrator Thu 26 Jan 2006 02:37 AM #8

OK, found it. It was indeed related to the new code for colouring only the foreground or background.

What would cause the problem was if two triggers coloured the same line, and the first one coloured it in RGB mode (ie. using "Change colour and style to ... Other"). After this, any second attempt to colour that line would cause the crash.

Thus, the single trigger you posted did not, in itself, cause the crash. You must have had another one that was evaluted earlier, that changed the colour of part of that line.

This has been fixed in version 3.73.

Nick Gammon Australia Forum Administrator Thu 26 Jan 2006 03:05 AM #9

Version 3.73 is now available.